Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images not always rendered #18

Closed
th-otto opened this issue Dec 17, 2024 · 9 comments
Closed

Images not always rendered #18

th-otto opened this issue Dec 17, 2024 · 9 comments

Comments

@th-otto
Copy link

th-otto commented Dec 17, 2024

With same example as in sammycage/plutovg#43:

clock

Some of the circles are not rendered:

clock svg

The hand and the text isn't rendered either. This is independent on the bigendian patch and also happens on linux.

@sammycage
Copy link
Owner

Hi,

I reviewed the attached file and compared the rendering in Chrome and PlutoSVG on Linux. However, I'm unable to observe any noticeable differences between the two when the image is rendered. This is the output image when rendered with the plutosvg svg2png program:

hello

@th-otto
Copy link
Author

th-otto commented Dec 17, 2024

Hm that's strange. Are you sure are using the svg2png from plutosvg, and not from LunaSVG? I recompiled it again (without plutovg being installed, so it is fetched from github) and still get the same result on linux.

@sammycage
Copy link
Owner

I reinstalled the latest PlutoVG and PlutoSVG from GitHub and ensured that I am running svg2png from the PlutoSVG build directory. It renders correctly as before.

Could you please run camera2png from the PlutoSVG build directory and share the output image with me? This might help identify if there's anything unusual in your setup.

Screenshot from 2024-12-17 14-25-18

Screenshot from 2024-12-17 14-25-04

@th-otto
Copy link
Author

th-otto commented Dec 17, 2024

The generate camera.png looks ok to me:

camera

@sammycage
Copy link
Owner

sammycage commented Dec 17, 2024

My bad! I just realized I was using the old SVG file from sammycage/plutovg#43. That was my oversight, and I appreciate your patience.

After testing with the current file, I noticed it renders incorrectly with PlutoSVG.

@th-otto
Copy link
Author

th-otto commented Dec 17, 2024

Oops. Whats the difference? The SVG files i attached are identical.

@sammycage
Copy link
Owner

My bad again ;). I just noticed that I removed all the image tags in the original SVG file when fixing the Endianness problems in sammycage/plutovg#43.

@sammycage
Copy link
Owner

sammycage commented Dec 17, 2024

Phew 😅 Thanks for reporting this issue! It has been fixed with the latest commit 20606c7. Test it out and let me know your feedback!

@th-otto
Copy link
Author

th-otto commented Dec 17, 2024

Yes, perfect, thank you for this quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants