chore: ban no arguments in IsListOrTuple
#106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
changed the title
IsListOrTupleIsListOrTuple
FBruzzesi
commented
Sep 15, 2024
Comment on lines
+90
to
+92
| allowed_type: Union[ | ||
| Tuple[Type[List[Any]]], Tuple[Type[Tuple[Any, ...]]], Tuple[Type[List[Any]], Type[Tuple[Any, ...]]] | ||
| ] = (list, tuple) |
There was a problem hiding this comment.
This is a hack to be able to perform: ' or '.join(t.__name__ for t in self.allowed_type) and provide an error message specialized for each class.
The only other place in which allowed_type is if not isinstance(other, self.allowed_type): which would still be ok with the change:
- if not isinstance(other, list):
+ if not isinstance(other, (list, )):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #96