Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception ArgumentError in Hyrax::GenericWorks#show when viewing a work #4937

Closed
elrayle opened this issue May 7, 2021 · 2 comments
Closed
Labels
Milestone

Comments

@elrayle
Copy link
Contributor

elrayle commented May 7, 2021

Descriptive summary

An exception when viewing a work on the work show page. See image below.

Rationale

Exceptions should not be raised when a work is correctly created.

Expected behavior

Creating a work with all required fields should create the work without error.

Actual behavior

An exception occurs while the work is saving.

image

Steps to reproduce the behavior

  1. Login
  2. Click Share Work on the home page
  3. Select Generic Work for type
  4. Fill in required fields and save

Exception is thrown. Note that the same thing happens with works that already existed.

Related work

Link to related tickets or prior related work here.

@elrayle elrayle added the bug label May 7, 2021
@no-reply
Copy link
Contributor

no-reply commented May 7, 2021

this seems to be caused by Rails 5.2.6, which is a security release that introduces this error message.

we'll need to come up with and test a fix, and release it on the 2.x and 3.x series'

@no-reply
Copy link
Contributor

no-reply commented May 7, 2021

the fix is merged in main via #4943

i'm working up draft release notes for a release containing this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants