Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyrax 5.0.0.rc2 depends on riiif #6461

Closed
1 task
marrus-sh opened this issue Nov 20, 2023 · 0 comments · Fixed by #6495
Closed
1 task

Hyrax 5.0.0.rc2 depends on riiif #6461

marrus-sh opened this issue Nov 20, 2023 · 0 comments · Fixed by #6495
Labels

Comments

@marrus-sh
Copy link
Collaborator

Descriptive summary

Hyrax 5.0.0.rc2 defines RiiifFile < Riiif::File in app/models/concerns/hyrax/riiif_file.rb, which naturally breaks in production if riiif is not installed.

My guess is that any Hyrax application which uses the Hyrax install generator with the skip-riiif option will break on Hyrax 5.0.0.rc2.

Steps to reproduce the behavior

  1. Create a Hyrax application with the skip-riiif option (do not install riiif)
  2. Try to run the application (without autoloading enabled)
  3. The application will fail, because app/models/concerns/hyrax/riiif_file.rb tries to subclass Riiif::File, which is not defined.

Workaround

Just define :⁠—

module Riiif
  class File
  end
end

—⁠: in the non‐Riiif‐supporting application.

Acceptance Criteria/Expected Behavior

  • Hyrax does not require riiif be installed to run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant