File Upload Progress Bars Are Missing

[conorom]

Descriptive summary

File Upload Progress Bars Are Missing

Steps to reproduce the behavior in User Interface (UI)

1. Go to add/edit Work page, or "Create Batch of Works" page (possibly other places that use the blueimp jQuery file uploader
2. Select "Files" tab
3. Click "+ Add files..." ("+ Add folder..." also works)
4. Select your files (or folder) and click "open" (or "upload") button(s)

Actual behavior (include screenshots if available)

in Hyrax 4.0.x, Hyrax 5.0.x and main you see nothing at all until the upload completes. This can be a long time (depending on file sizes and network speed), and therefore pretty confusing to the user. It can look like nothing has happened at all after their selection was made.

Acceptance Criteria/Expected Behavior

Both of the highlighted areas in this screenshot should be present. This screenshot was taken on Hyrax 3.5.0

Neither of them show up right now:

Related work

I've traced this problem back to two separate commits.

The blueimp file uploader needed to be fixed to work with Bootstrap 4. That was done in this commit which was rolled into a whole bunch of changes that made up the initial release of Hyrax 4.0.x
That fix failed to account for the "overall progress bar/count" at the bottom of the screenshot.
It looks like this additional class was applied but maybe not everywhere it was needed, and maybe that's not the best fix for this thing anyways.
AFAICT this solution from the same SO page seems to fix all of the progress bars without the addition of the show class.
The pre-existing fade_class_if_not_test stuff might be related to system specs or something. I would love to get rid of that too if it doesn't break any current tests.

The top highlighted part in the screenshot above, where the upload progress bars per file are shown was borked here. I will probably reopen the related issue #1267, as that change needs to be rolled back.

I think that covers it.

[conorom]

In the end I backed away from removing the fade_class_if_not_test
Whether they actually do something useful right now is hard to say. The offending spec mentioned in the refs where they were added did not fail CI for me with that stuff removed, but that's not definitive with an intermittent failure.

There has been a ton of churn in that spec since then (7 years) and a lot of it seems to be fighting such intermittent CI failures.
Makes no sense for me to try to figure any of that out in my little PR.