Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Remove human_readable_type from the model #304

Open
jcoyne opened this issue Nov 9, 2017 · 0 comments
Open

Proposal: Remove human_readable_type from the model #304

jcoyne opened this issue Nov 9, 2017 · 0 comments

Comments

@jcoyne
Copy link
Member

jcoyne commented Nov 9, 2017

This method is problematic because it can't be internationalized and it doesn't properly support irregular plurals. Can we move this to an indexer and have it call I18n.translate('valkyrie.models.book') instead?

I'd much rather support http://api.rubyonrails.org/classes/ActiveModel/Name.html#method-i-human
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcoyne @tpendragon