Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set() has a name clash with the ES6 Set object #215

Open
nigelmegitt opened this issue May 27, 2021 · 1 comment
Open

Set() has a name clash with the ES6 Set object #215

nigelmegitt opened this issue May 27, 2021 · 1 comment
Labels
Milestone

Comments

@nigelmegitt
Copy link
Contributor

The class/function corresponding to the TTML set element is called Set, but there is already an ES6 standard object called Set, so this is likely to cause confusion or errors in the future (especially if we adopt ES6 as per #214). Consider renaming it to something without a name clash.

It's possible that there are other name clashes too; I haven't checked.

@BasBastian
Copy link

#229 might be the PR that solves that issue. Same goes for "Image" class, that is part of any modern browser's API

@palemieux palemieux added the 2.0 label May 2, 2024
@palemieux palemieux added this to the 2.0 Release milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants