Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

could not tag file. Argument #1 ($process) must be of type M4bTool\Executables\Process #199

Closed
djdembeck opened this issue Oct 5, 2022 · 3 comments

Comments

@djdembeck
Copy link

djdembeck commented Oct 5, 2022

When merging a folder of mp3 files, something is going wrong during the tag process it seems. I am using these Docker versions for deps:

FROM sandreas/ffmpeg:5.0.1-3 as ffmpeg
FROM sandreas/mp4v2:2.1.1 as mp4v2
FROM sandreas/fdkaac:2.0.1 as fdkaac

M4B command: ['/usr/local/bin/m4b-tool', 'merge', '--output-file=/output/Matt Haig/The Humans/The Humans - A Novel.m4b', '--name=The Humans - A Novel', '--album=The Humans', '--artist=Mark Meadows', '--albumartist=Matt Haig', '--year=2013', '--description=The critically acclaimed author of The Radleys shares a clever, heartwarming, and darkly insightful novel about an alien who comes to Earth to save humans from themselves....', '--genre=Literature & Fiction/Science Fiction & Fantasy/Genre Fiction/Family Life/Literary Fiction/Science Fiction/Humorous', '--comment=Unabridged', '--cover=/input/Matt Haig - The Humans_cover.jpg', '--force', '--no-chapter-reindexing', '--no-cleanup', '--ignore-source-tags', '--jobs=24', '-vvv', '--audio-bitrate=65000', '--audio-samplerate=44100', PosixPath('/input/Matt Haig - The Humans')]

Error:

tagFile - filename: /tmp/m4b-tool/tmp_The Humans - A Novel.m4b
full tag: {"album":"The Humans","albumArtist":"Matt Haig","artist":"Mark Meadows","comment":"Unabridged","cover":"\/input\/Matt Haig - The Humans_cover.jpg","description":"The critically acclaimed author of The Radleys shares a clever, heartwarming, and darkly insightful novel about an alien who comes to Earth to save humans from themselves....","encoder":"m4b-tool","genre":"Literature & Fiction\/Science Fiction & Fantasy\/Genre Fiction\/Family Life\/Literary Fiction\/Science Fiction\/Humorous","title":"The Humans - A Novel","type":2,"year":"2013"}
'mp4tags' '-help'
'mp4tags' '-A' 'The Humans' '-a' 'Mark Meadows' '-s' 'The Humans - A Novel' '-g' 'Literature & Fiction/Science Fiction & Fantasy/Genre Fiction/Family Life/Literary Fiction/Science Fiction/Humorous' '-m' 'The critically acclaimed author of The Radleys shares a clever, heartwarming, and darkly insightful novel about an alien who comes to Earth to save humans from themselves....' '-R' 'Matt Haig' '-y' '2013' '-c' 'Unabridged' '-E' 'm4b-tool' '-i' '2' '/tmp/m4b-tool/tmp_The Humans - A Novel.m4b'
could not tag file /tmp/m4b-tool/tmp_The Humans - A Novel.m4b, error: M4bTool\Executables\AbstractExecutable::handleExitCode(): Argument #1 ($process) must be of type M4bTool\Executables\Process, Symfony\Component\Process\Process given, called in phar:///usr/local/bin/m4b-tool/src/library/Executables/Mp4tags.php on line 106
#0 phar:///usr/local/bin/m4b-tool/src/library/Executables/Mp4tags.php(106): M4bTool\Executables\AbstractExecutable->handleExitCode()
#1 phar:///usr/local/bin/m4b-tool/src/library/Executables/Mp4tags.php(71): M4bTool\Executables\Mp4tags->storeTagsToFile()
#2 phar:///usr/local/bin/m4b-tool/src/library/Executables/Mp4v2Wrapper.php(72): M4bTool\Executables\Mp4tags->writeTag()
#3 phar:///usr/local/bin/m4b-tool/src/library/Audio/BinaryWrapper.php(270): M4bTool\Executables\Mp4v2Wrapper->writeTag()
#4 phar:///usr/local/bin/m4b-tool/src/library/Command/AbstractConversionCommand.php(260): M4bTool\Audio\BinaryWrapper->writeTag()
#5 phar:///usr/local/bin/m4b-tool/src/library/Command/MergeCommand.php(917): M4bTool\Command\AbstractConversionCommand->tagFile()
#6 phar:///usr/local/bin/m4b-tool/src/library/Command/MergeCommand.php(533): M4bTool\Command\MergeCommand->tagMergedFile()
#7 phar:///usr/local/bin/m4b-tool/src/library/Command/MergeCommand.php(424): M4bTool\Command\MergeCommand->processInputFiles()
#8 phar:///usr/local/bin/m4b-tool/src/library/Command/MergeCommand.php(185): M4bTool\Command\MergeCommand->processFiles()
#9 phar:///usr/local/bin/m4b-tool/vendor/symfony/console/Command/Command.php(255): M4bTool\Command\MergeCommand->execute()
#10 phar:///usr/local/bin/m4b-tool/vendor/symfony/console/Application.php(1009): Symfony\Component\Console\Command\Command->run()
#11 phar:///usr/local/bin/m4b-tool/vendor/symfony/console/Application.php(273): Symfony\Component\Console\Application->doRunCommand()
#12 phar:///usr/local/bin/m4b-tool/vendor/symfony/console/Application.php(149): Symfony\Component\Console\Application->doRun()
#13 phar:///usr/local/bin/m4b-tool/bin/m4b-tool.php(52): Symfony\Component\Console\Application->run()
#14 /usr/local/bin/m4b-tool(10): require('...')
#15 {main}
trace: #0 phar:///usr/local/bin/m4b-tool/src/library/Executables/Mp4tags.php(106): M4bTool\Executables\AbstractExecutable->handleExitCode()
#1 phar:///usr/local/bin/m4b-tool/src/library/Executables/Mp4tags.php(71): M4bTool\Executables\Mp4tags->storeTagsToFile()
#2 phar:///usr/local/bin/m4b-tool/src/library/Executables/Mp4v2Wrapper.php(72): M4bTool\Executables\Mp4tags->writeTag()
#3 phar:///usr/local/bin/m4b-tool/src/library/Audio/BinaryWrapper.php(270): M4bTool\Executables\Mp4v2Wrapper->writeTag()
#4 phar:///usr/local/bin/m4b-tool/src/library/Command/AbstractConversionCommand.php(260): M4bTool\Audio\BinaryWrapper->writeTag()
#5 phar:///usr/local/bin/m4b-tool/src/library/Command/MergeCommand.php(917): M4bTool\Command\AbstractConversionCommand->tagFile()
#6 phar:///usr/local/bin/m4b-tool/src/library/Command/MergeCommand.php(533): M4bTool\Command\MergeCommand->tagMergedFile()
#7 phar:///usr/local/bin/m4b-tool/src/library/Command/MergeCommand.php(424): M4bTool\Command\MergeCommand->processInputFiles()
#8 phar:///usr/local/bin/m4b-tool/src/library/Command/MergeCommand.php(185): M4bTool\Command\MergeCommand->processFiles()
#9 phar:///usr/local/bin/m4b-tool/vendor/symfony/console/Command/Command.php(255): M4bTool\Command\MergeCommand->execute()
#10 phar:///usr/local/bin/m4b-tool/vendor/symfony/console/Application.php(1009): Symfony\Component\Console\Command\Command->run()
#11 phar:///usr/local/bin/m4b-tool/vendor/symfony/console/Application.php(273): Symfony\Component\Console\Application->doRunCommand()
#12 phar:///usr/local/bin/m4b-tool/vendor/symfony/console/Application.php(149): Symfony\Component\Console\Application->doRun()
#13 phar:///usr/local/bin/m4b-tool/bin/m4b-tool.php(52): Symfony\Component\Console\Application->run()
#14 /usr/local/bin/m4b-tool(10): require('...')
#15 {main}
@djdembeck djdembeck changed the title could not tag file could not tag file. Argument #1 ($process) must be of type M4bTool\Executables\Process Oct 5, 2022
@sandreas
Copy link
Owner

sandreas commented Oct 6, 2022

Ah, thank you for reporting this. Another namespace issue after refactoring a method. Fixed in code and in latest docker. After your confirmation, that it is fixed, I'll publish another dated docker tag.

@djdembeck
Copy link
Author

Thanks for the quick response! Your update fixed the error.

@sandreas
Copy link
Owner

sandreas commented Oct 6, 2022

Great, thanks for the feedback. I definitely have to establish some automated acceptance and regression tests :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants