fix: support nested node_modules

sandworm-hq · Sep 27, 2022 · 4a4c0e7 · 4a4c0e7
1 parent 78559e7
commit 4a4c0e7
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/src/module.js b/src/module.js
@@ -78,7 +78,7 @@ export const mapStackItemToSource = (item) => {
 
 export const getNodeModuleName = (location) => {
   const components = location.split('/');
-  const nodeModulesIndex = components.findIndex((v) => v === 'node_modules');
+  const nodeModulesIndex = components.lastIndexOf('node_modules');
   let moduleName = components[nodeModulesIndex + 1];
   // Names starting with `@` are organizations, so it's good to get
   // a bit more context by also grabbing the next path component

diff --git a/tests/unit/module.test.js b/tests/unit/module.test.js
@@ -261,6 +261,14 @@ describe('module', () => {
       ).toBe('lodash');
     });
 
+    test('should indicate module name for a nested node-modules path', () => {
+      expect(
+        getModuleNameFromLocation(
+          '/Users/jason/code/sandworm/node_modules/lodash/node_modules/react/index.js',
+        ),
+      ).toBe('react');
+    });
+
     test('should grab full name for org paths', () => {
       expect(
         getModuleNameFromLocation(