feat(wrapper): remove dep to @types/vscode #167
Merged
+87
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could cause consuming projects to have multiple versions of @types/vscode which can cause compliation errors in TSC BREAKING CHANGE: `getConfigurations` and `onDidChangeConfiguration` properties were removed from the `configureLogger` public API
bd82
force-pushed
the
refactor_wrapper
branch
from
14f6b81 to
59f0a5d
Compare
|
@tal-sapan let me know if there are any issues and I will fix in a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could cause consuming projects to have multiple versions of
@types/vscode which can cause compliation errors in TSC
BREAKING CHANGE:
getConfigurationsandonDidChangeConfigurationpropertieswere removed from the
configureLoggerpublic API