Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly allow a base importer without a base URL #3831

Open
2 of 3 tasks
nex3 opened this issue Apr 9, 2024 · 1 comment
Open
2 of 3 tasks

Explicitly allow a base importer without a base URL #3831

nex3 opened this issue Apr 9, 2024 · 1 comment
Labels
enhancement New feature or request requires deprecation Blocked on a deprecation cycle

Comments

@nex3
Copy link
Contributor

nex3 commented Apr 9, 2024

See sass/dart-sass#2208. This already implicitly throws an error per spec due to trying to do WHATWG URL resolution with a null base, but the spec is not explicit about this and in practice Dart Sass doesn't throw an error.

@nex3
Copy link
Contributor Author

nex3 commented Apr 9, 2024

Per sass/dart-sass#2208 (comment), we've decided not to deprecate this after all. Instead, I'll update the specification to explicitly allow it.

@nex3 nex3 changed the title Explicitly disallow a base importer without a base URL Explicitly allow a base importer without a base URL Apr 9, 2024
@nex3 nex3 added enhancement New feature or request requires deprecation Blocked on a deprecation cycle labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request requires deprecation Blocked on a deprecation cycle
Projects
None yet
Development

No branches or pull requests

1 participant