Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 100dvh instead of 100vh (min-h-screen) #127

Closed
mdmrk opened this issue Sep 26, 2023 · 3 comments
Closed

Use 100dvh instead of 100vh (min-h-screen) #127

mdmrk opened this issue Sep 26, 2023 · 3 comments

Comments

@mdmrk
Copy link
Contributor

mdmrk commented Sep 26, 2023

One advantage would be on mobile view where footer is not full visible. I don't think Tailwind supports it yet so I'll be using custom values meanwhile

body {
@apply flex min-h-screen flex-col bg-skin-fill font-mono text-skin-base
selection:bg-skin-accent selection:bg-opacity-70 selection:text-skin-inverted;
}

 body { 
   @apply flex min-h-[100dvh] flex-col bg-skin-fill font-mono text-skin-base  
   selection:bg-skin-accent selection:bg-opacity-70 selection:text-skin-inverted; 
 } 
@satnaing
Copy link
Owner

satnaing commented Oct 3, 2023

Thanks for pointing this out.
How about SVH with min-height?
Just a side note, "Can I use" said these units are not supported in some browsers. (However, it covers 90% of global browser usage)

@mdmrk
Copy link
Contributor Author

mdmrk commented Oct 3, 2023

Haven't tried, but i may work the same as dvh

@satnaing
Copy link
Owner

satnaing commented Oct 6, 2023

Yep. I'll use svh for now since this might be the most optimal way for this case.
Thank you for pointing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants