Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: astro-3.0 and all dependencies updated #112

Closed
wants to merge 6 commits into from

Conversation

Luks17
Copy link
Contributor

@Luks17 Luks17 commented Sep 5, 2023

closes #111

Description: This PR aims to be a simple port of astro-paper to Astro 3.0, no new features introduced in that update were added. A lot of styles were broken in the update, so this PR also fixes them.

@timrwwatson
Copy link

Apologies if dumb question: is there a way to sort out the deprecation warnings I assume your getting in [ogTitle].svg.ts for returning a simple object etc ?

@Luks17
Copy link
Contributor Author

Luks17 commented Sep 6, 2023

Apologies if dumb question: is there a way to sort out the deprecation warnings I assume your getting in [ogTitle].svg.ts for returning a simple object etc ?

I purposefully avoided fixing that because I did not find it on the changelog and didn't want to break it. However, I just found it documented at the very end of the page, so will try to fix it later.

@Luks17
Copy link
Contributor Author

Luks17 commented Sep 6, 2023

Apologies if dumb question: is there a way to sort out the deprecation warnings I assume your getting in [ogTitle].svg.ts for returning a simple object etc ?

Should be solved now

@timrwwatson
Copy link

timrwwatson commented Sep 6, 2023

Apologies if dumb question: is there a way to sort out the deprecation warnings I assume your getting in [ogTitle].svg.ts for returning a simple object etc ?

Should be solved now

Works for me, I think there might have been another warning in rss.xml.ts, but i've modified/forked my original and since then done other things. So I think that one might need something too?

return new Response(JSON.stringify(rss({
    title: SITE.title,
    description: SITE.desc,
    site: SITE.website,
    items: sortedPosts.map(({ data }) => ({
      link: `posts/${slugify(data)}`,
      title: data.title,
      description: data.description,
      pubDate: new Date(data.pubDatetime),
    })),
  })));

such as ^^

While testing your changes from satnaing#112 locally, I encountered this issue: `Type 'ImageMetadata' is not assignable to type 'string'.ts` - Based on the Astro 3.0 changes, it seems that passing the src via `.src` is the intended way to use this now
Luks17 and others added 2 commits September 6, 2023 18:27
Access logo via `.src` to avoid `ImageMetadata` type issue
@satnaing
Copy link
Owner

I truly appreciate your PR and your dedication to this. Thank you for your hard work.

I've also been working on the same issue locally, and I noticed that many of the changes in your PR are similar or identical to what I've been working on. If there are any changes, features, or bug fixes that you've made, which are not present in my PR, would you be open to merging them into my PR?

@Luks17
Copy link
Contributor Author

Luks17 commented Sep 15, 2023

I truly appreciate your PR and your dedication to this. Thank you for your hard work.

I've also been working on the same issue locally, and I noticed that many of the changes in your PR are similar or identical to what I've been working on. If there are any changes, features, or bug fixes that you've made, which are not present in my PR, would you be open to merging them into my PR?

I will check it out!

@alec-c4
Copy link

alec-c4 commented Sep 15, 2023

Guys, may I ask you to add RTFM how to update existing blog with this release?

@satnaing
Copy link
Owner

@alec-c4
That will also be added soon. In the meantime, if you'd like, you can start experimenting with the new version on your own by examining the commit history, such as this PR or mine.

@Luks17 Luks17 closed this Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to astro 3.x
5 participants