-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: astro-3.0 and all dependencies updated #112
Conversation
Apologies if dumb question: is there a way to sort out the deprecation warnings I assume your getting in [ogTitle].svg.ts for returning a simple object etc ? |
I purposefully avoided fixing that because I did not find it on the changelog and didn't want to break it. However, I just found it documented at the very end of the page, so will try to fix it later. |
Should be solved now |
Works for me, I think there might have been another warning in rss.xml.ts, but i've modified/forked my original and since then done other things. So I think that one might need something too?
|
While testing your changes from satnaing#112 locally, I encountered this issue: `Type 'ImageMetadata' is not assignable to type 'string'.ts` - Based on the Astro 3.0 changes, it seems that passing the src via `.src` is the intended way to use this now
Access logo via `.src` to avoid `ImageMetadata` type issue
I truly appreciate your PR and your dedication to this. Thank you for your hard work. I've also been working on the same issue locally, and I noticed that many of the changes in your PR are similar or identical to what I've been working on. If there are any changes, features, or bug fixes that you've made, which are not present in my PR, would you be open to merging them into my PR? |
I will check it out! |
Guys, may I ask you to add RTFM how to update existing blog with this release? |
closes #111
Description: This PR aims to be a simple port of astro-paper to Astro 3.0, no new features introduced in that update were added. A lot of styles were broken in the update, so this PR also fixes them.