Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log in the case that Crack barfs while parsing SOAP response #170

Closed
wants to merge 1 commit into from

Conversation

trampoline
Copy link

currently Savon::SOAP::XML.parse swallows any Exceptions from Crack silently. this is evil

this patch logs any Crack Exceptions to Savon.log. I would prefer that Exceptions should propagate to caller, but presumably you took a decision not to do this for some reason, in which case logging is appropriate

:c

@rubiii
Copy link
Contributor

rubiii commented Apr 5, 2011

thanks for the pull request. i think you're right about raising these exceptions and it's the default behavior of v0.9.0. please read the changelog and update if you can.

@rubiii rubiii closed this Apr 5, 2011
@trampoline
Copy link
Author

great, thanks : 0.9.1 seems to work just fine

:c


rubiii
mailto:reply@reply.github.com
5 April 2011 18:49

thanks for the pull request. i think you're right about raising these
exceptions and it's the default behavior of
v0.9.0. please [read
the changelog] and update if you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants