Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0 release breaks integration with style="rpc" operations #118

Closed
hss-mateus opened this issue Feb 19, 2024 · 1 comment · Fixed by #119
Closed

4.0 release breaks integration with style="rpc" operations #118

hss-mateus opened this issue Feb 19, 2024 · 1 comment · Fixed by #119

Comments

@hss-mateus
Copy link
Contributor

If I understand it correctly, PR #114 added a check in the style attribute of an operation to know if it's an document.

soap_document = soap_operation["style"] if soap_operation

Apparently, a comparison is missing here, so it's always considering that it's a document style.
A solution is to just compare with the desired value:

 soap_document = soap_operation["style"] == "document" if soap_operation
@pcai
Copy link
Member

pcai commented Feb 20, 2024

Thanks. Can you provide a pr with a test case please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants