Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not follow 3xx redirects #18

Open
zacharydanger opened this issue Nov 29, 2012 · 3 comments
Open

Does not follow 3xx redirects #18

zacharydanger opened this issue Nov 29, 2012 · 3 comments

Comments

@zacharydanger
Copy link

For instance the WSDL: https://services.PWSDemo.com/CreditCardTransactionService.svc?wsdl

This produces a 307 redirect with a location header. Instead of following the redirect, it assumes there's been an error and raises an HTTPError.

@rubiii
Copy link
Contributor

rubiii commented Jul 3, 2013

this will be fixed with savon version 3 by handing the control of http-requests to the user.

@rubiii rubiii closed this as completed Jul 3, 2013
@dfoleyAFG
Copy link

Is this fixed? I am having the same problem...

@tjarratt
Copy link
Contributor

@dfoleyAFG it's still an unresolved issue. From looking at the discussion on the still-open HTTPI issue, it seems like it wasn't clear whether this should be fixed in Wasabi or HTTPI. It seems fairly straightforward to fix, but reading some of the history... it does reveal itself to be rather complicated.

If someone issued a PR (with tests) for this behavior to Wasabi or HTTPI I'd definitely try to get it merged in. Right now I'm learning towards implementing it in Wasabi because of some quirks in getting all of the adapters to support this.

Interested parties might want to read savonrb/httpi#67 for some more history, information and discussion about how this might be solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants