Convert to TypeScript, rework support for React 18, Refresh latest logic from JotForm #6
Conversation
…gic from JotForm.
|
@sbayd @mg-aceik Hey on both the main branch, as well as this PR we are getting a linting error when using this module: Type error: Could not find a declaration file for module 'jotform-react'. '/app/node_modules/jotform-react/dist/index.cjs.js' implicitly has an 'any' type. Wanted to flag this, thanks! |
|
@awc120 this PR isn't published to NPM yet so that issue isn't from this. To use this PR just copy the https://github.com/mg-aceik/jotform-react/blob/main/lib/index.tsx into your solution. |
|
can we publish this? |
There was a problem hiding this comment.
Is there a reason the lockfile is deleted? It should be regenerated and added to this pr. Otherwise, I think it looks good!
(edit) just realized your initial comment mentioned this. Should still get corrected prior to merge. I am not sure if this is maintained anymore though
|
@mg-aceik would it be possible to generate so we can release this update? |
|
@mg-aceik can we get this published? |
|
Someone else will need to take over the requested changes here, I'm not using Jotform anymore - switched to Paperform. |
I don't use pnpm so haven't checked in the lock file.
I also haven't checked the storybook, I was testing on a separate project.
Fixed #5.