From 7a4ca4da359f82f0b4a5c1a25349825c425695b6 Mon Sep 17 00:00:00 2001 From: Sebastian Blauth Date: Fri, 18 Nov 2022 07:02:05 +0100 Subject: [PATCH] Fixed "project_to_admissible_set" to return no value --- cashocs/_forms/control_form_handler.py | 9 +-------- cashocs/_forms/form_handler.py | 4 +--- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/cashocs/_forms/control_form_handler.py b/cashocs/_forms/control_form_handler.py index a43d3242..0564dd70 100644 --- a/cashocs/_forms/control_form_handler.py +++ b/cashocs/_forms/control_form_handler.py @@ -327,9 +327,7 @@ def restrict_to_inactive_set( return b - def project_to_admissible_set( - self, a: List[fenics.Function] - ) -> List[fenics.Function]: + def project_to_admissible_set(self, a: List[fenics.Function]) -> None: """Project a function to the set of admissible controls. Projects a control type function ``a`` onto the set of admissible controls @@ -339,9 +337,6 @@ def project_to_admissible_set( a: The function which is to be projected onto the set of admissible controls (is overwritten) - Returns: - The result of the projection (overwrites input ``a``) - """ for j in range(self.control_dim): if self.require_control_constraints[j]: @@ -354,8 +349,6 @@ def project_to_admissible_set( ) a[j].vector().apply("") - return a - def _compute_gradient_equations(self) -> None: """Calculates the variational form of the gradient equation.""" self.gradient_forms_rhs = [ diff --git a/cashocs/_forms/form_handler.py b/cashocs/_forms/form_handler.py index 09a0a5c2..fce52028 100644 --- a/cashocs/_forms/form_handler.py +++ b/cashocs/_forms/form_handler.py @@ -320,8 +320,6 @@ def update_scalar_product(self) -> None: """Updates the scalar product.""" pass - def project_to_admissible_set( - self, a: List[fenics.Function] - ) -> List[fenics.Function]: + def project_to_admissible_set(self, a: List[fenics.Function]) -> None: """Projects a function ``a`` onto the admissible set.""" pass