Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize disk copy for multipart uploads #52

Open
sbrudenell opened this issue Aug 14, 2024 · 0 comments
Open

optimize disk copy for multipart uploads #52

sbrudenell opened this issue Aug 14, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@sbrudenell
Copy link
Owner

with #51, we copy from the send stream to disk for multipart uploads. we currently do this in python code, which is slow. we could implement a faster copy using sendfile() and splice().

we could also reuse buffers with readinto() for the slow case.

Some notes:

  • sendfile() requires mmap-capable input, so won't work for our normal case
  • splice() requires 3.10+ and a capable filesystem
@sbrudenell sbrudenell added the enhancement New feature or request label Aug 14, 2024
@sbrudenell sbrudenell self-assigned this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant