Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AshScriptPlugin does not add process_args() to ash-template #1254

Closed
farico opened this issue Aug 21, 2019 · 3 comments
Closed

AshScriptPlugin does not add process_args() to ash-template #1254

farico opened this issue Aug 21, 2019 · 3 comments

Comments

@farico
Copy link
Contributor

farico commented Aug 21, 2019

Expected behaviour

After adding enablePlugins(AshScriptPlugin) to build.sbt and running sbt stage a startup script is generated and it supports passing JAVA_OPTS when running app from command line:
sh app/target/universal/stage/bin/appName -Dconfig.resource=/myconfig.conf

Actual behaviour

After adding enablePlugins(AshScriptPlugin) to build.sbt and running sbt stage a startup script is generated. Startup shell script is missing process_args () command which is in JavaAppPackaging and as a result when running appliction with: sh app/target/universal/stage/bin/appName -Dconfig.resource=/myconfig.conf -Dconfig.resource is not passed to addJava command.

Information

  • sbt-native-packager version: 1.4.0
  • sbt version: 1.2.8
  • Build system: MacOS Mojave 10.14
  • Target system: CentOS 7

Overriding ash-template and adding process_args() and then calling it before java_cmd solves the issue.

@muuki88
Copy link
Contributor

muuki88 commented Aug 21, 2019

Thanks @farico for you feature request. Would you like to open a pull request for this? If yes, I'm happy to help you with any question.

@farico
Copy link
Contributor Author

farico commented Aug 21, 2019

Sure, I want to work on this.

@farico
Copy link
Contributor Author

farico commented Aug 21, 2019

@muuki88 I created a pull request for this feature. I've taken process_args() from bash-template and removed process_my_args.

@muuki88 muuki88 closed this as completed Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants