Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native package heavily uses and recommends <+=, which is deprecated #919

Closed
clhodapp opened this issue Nov 20, 2016 · 4 comments
Closed
Assignees
Labels
project General project issues

Comments

@clhodapp
Copy link

clhodapp commented Nov 20, 2016

The now-deprecated sbt dsl operator, <+=, is used frequently in the source, build, and docs for native packager. This operator is deprecated as of the latest release of sbt, is going away in sbt 1.0, and should be replaced with just a += and a postfix call to .taskValue. It's especially problematic that the docs recommend using it because it sets users up for having to update their builds later and could cause them to see deprecation warnings, as well as requiring them to learn about a concept that isn't explained in the sbt documentation (since it's deprecated).

@muuki88
Copy link
Contributor

muuki88 commented Nov 20, 2016

Yes, you are absolutely right. All newer stuff already uses the recommended operators, but there's a lot of untouched, old code.

I'm happy for every pull request that replaces a deprecated operator 😃

@muuki88 muuki88 self-assigned this Jan 16, 2017
@muuki88 muuki88 added the project General project issues label Jan 16, 2017
@muuki88
Copy link
Contributor

muuki88 commented Jan 25, 2017

I hope I fixed them all in #931

@muuki88 muuki88 closed this as completed Jan 25, 2017
@clhodapp
Copy link
Author

Wonderful!

@clhodapp
Copy link
Author

That was a lot of work, thanks for picking it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project General project issues
Projects
None yet
Development

No branches or pull requests

2 participants