Add dockerBuildEnvVars setting, fix docker test failure in CI
#1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwickern
force-pushed
the
fix-docker-test
branch
3 times, most recently
from
ebfa780 to
f8dfe5a
Compare
dwickern
force-pushed
the
fix-docker-test
branch
from
2db7b6d to
9e78399
Compare
dwickern
changed the title
dockerBuildEnvVars setting, fix docker test failure in CI
dwickern
commented
Apr 10, 2024
| dockerBuildEnvVars.value | ||
| .get("DOCKER_BUILDKIT") | ||
| .orElse(sys.env.get("DOCKER_BUILDKIT")) | ||
| .map(_ == "1") |
There was a problem hiding this comment.
Docker uses strconv.ParseBool which accepts some other values, but we'll assume the value is either 1 or 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker BuildKit became the default in Docker v23.0 which caused the test to fail. BuildKit doesn't expose intermediate containers as images, so the cleanup setting
dockerAutoremoveMultiStageIntermediateImagesis not relevant when running BuildKit.I've added a setting
dockerBuildEnvVarswhich can be used to disable BuildKit:I've also improved BuildKit detection-- it now checks the docker version if
DOCKER_BUILDKITis not set.This incidentally fixes #1518