Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IncOptions.useOptimizedSealed not working for Scala 2.13 #1278

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Fix IncOptions.useOptimizedSealed not working for Scala 2.13 #1278

merged 1 commit into from
Nov 5, 2023

Conversation

Friendseeker
Copy link
Member

@Friendseeker Friendseeker commented Nov 5, 2023 •
edited
Loading

In ExtractUsedName.scala, whenever a pattern matching involving a sealed class is encountered, the dependency is registered, but only with Default scope instead of PatMat scope.

To fix it, an extra match case is added in handleClassicTreeNode to register the dependency in PatMat scope.

Closes #753 #1229

eed3si9n
eed3si9n approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 72101b7 into sbt:develop Nov 5, 2023
7 checks passed
@Friendseeker Friendseeker deleted the optimized_seal_fix branch November 5, 2023 20:42
@Friendseeker Friendseeker mentioned this pull request Nov 5, 2023
Merged
@lrytz lrytz mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

optimized sealed option may not be working for 2.13
2 participants
@Friendseeker @eed3si9n