Do not use invalidationResults
to compute next invalidations
#1312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
invalidationResults
inAnalysisCallback
is computed twice, once in API phase, once in dependency phase. It is not updated again after Java analysis, henceinvalidationResults
contains incorrect information for Java sources.Fix
Do not use
invalidationResults
when computingCompileCycleResult
.Trivia
I am not 100% certain yet, but this is probably the root cause of sbt/sbt#6183, as
invalidationResults
is added in Zinc 1.4.0 and Infinite incremental compilation sbt#6183 appears after Zinc 1.4.0 is releasedinvalidateTransitively
flag is set with the PR change.c.c. @LaCuneta This should fix #1311 or at least partially fix it (if #1311 has multiple causes).