Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sphinx documentation site #159

Merged
merged 11 commits into from
Dec 7, 2022
Merged

Add sphinx documentation site #159

merged 11 commits into from
Dec 7, 2022

Conversation

empicano
Copy link
Owner

I set up Sphinx!

The documentation is live at https://sbtinstruments.github.io/asyncio-mqtt. I thought about deploying to ReadTheDocs, but they show ads, so I stuck with GitHub Pages, even though the URL is not that nice.

It's still a bit rough on the edges. For now, I only copied the "Advanced usage" Section.

I want to clean up the README still (to not have duplication anywhere), add an introduction to the Sphinx docs, and integrate the information from the examples folder.

Let me know what you think! 😊

~Felix

Repository owner deleted a comment from codecov bot Nov 27, 2022
@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@db997d8). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head d53b5d7 differs from pull request most recent head c57cbaf. Consider uploading reports for the commit c57cbaf to get more accurate results

@@          Coverage Diff           @@
##             main    #159   +/-   ##
======================================
  Coverage        ?   91.0%           
======================================
  Files           ?       7           
  Lines           ?     714           
  Branches        ?     150           
======================================
  Hits            ?     650           
  Misses          ?      41           
  Partials        ?      23           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JonathanPlasse
Copy link
Collaborator

The section Topic filter does not contain filters with wildcards which could make believe that it is not possible.

@frederikaalund
Copy link
Collaborator

It looks really good! A very nice initiative, indeed. 👍

I like the simplicity of it as well. After all, asyncio-mqtt is a tiny wrapper around paho-mqtt.

Some suggestions for further work:

  • Add a "repo" link back to GitHub.
  • Similarly, add an "issue tracker" link to our GitHub-based issues page.

@empicano
Copy link
Owner Author

Thanks for the feedback! 😎

The section Topic filter does not contain filters with wildcards which could make believe that it is not possible.

You're right 👍 The new example for #147 includes wildcards.

Some suggestions for further work: [...]

Great ideas, done!

@empicano empicano changed the base branch from master to main December 6, 2022 13:53
@empicano empicano marked this pull request as ready for review December 7, 2022 00:12
@empicano empicano merged commit 36864cf into main Dec 7, 2022
@empicano empicano deleted the add-sphinx branch December 7, 2022 14:22
@JonathanPlasse
Copy link
Collaborator

Awesome 🎉

@empicano
Copy link
Owner Author

empicano commented Dec 7, 2022

Thank you! 😊

@frederikaalund
Copy link
Collaborator

Looks great! 😄 Well done. 👍 We really needed better docs sooner rather than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants