solidity-coverage hardhat plugin override the network object

[wighawag]

This line override the hre.network object :

solidity-coverage/plugins/resources/nomiclabs.utils.js

Lines 136 to 141 in 3c0f3a5

	env.network = {
	name: networkName,
	config: networkConfig,
	provider: provider,
	isHardhatEVM: isHardhatEVM
	}

This conflict with plugins that add field to the network object. (an example of such plugin is hardhat-deploy)

solidity-coverage should keep existing configuration.

[cgewecke]

Yes definitely, will fix.

[cgewecke]

@wighawag From your perspective, is the correct way to do this to merge with the existing properties on network?

e.g

env.network = Object.assign({ 
   name: networkName, 
   config: networkConfig, 
   provider: provider, 
   isHardhatEVM: isHardhatEVM 
 }, env.network) 

Or is this not enough? What modifications are you making on your end?

[wighawag]

Yes that would work. I am adding extra field to the network object that deploy scripts can then used to perform different things depending on their values: {tags, live, saveDeployments}.

But there was actually a bigger issue for hardhat-deploy.
In a recent version I was accessing hre.network.provider at import time and storing it in a variable.
This caused hardhat-deploy to hang on that version, ignoring the fact that solidity-coverage replaced with a new one on task execution.

This is I think a general problem with hardhat plugin api where it is not clear for plugin at what point they get called in relation to other plugins, hence why I created : NomicFoundation/hardhat#1374

I fixed it in hardhat-deploy by storing a lazyObject to the provider. This allow solidity-coverage to replace it and hadhat-deploy to get the modified version when it is actually needed