From fb0198b230de66918152e03f4c159735c09e493d Mon Sep 17 00:00:00 2001 From: Jacob Barber Date: Thu, 15 Nov 2018 12:13:56 -0500 Subject: [PATCH] Address CR comments --- docs/rules/DisableSyntax.md | 13 +++++++------ .../test/disableSyntax/DisableSyntaxBase.scala | 5 ++++- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/docs/rules/DisableSyntax.md b/docs/rules/DisableSyntax.md index 3edd86e74..b68365a43 100644 --- a/docs/rules/DisableSyntax.md +++ b/docs/rules/DisableSyntax.md @@ -55,16 +55,17 @@ DisableSyntax.regex = [ ] ``` -1. The first way has a simple object providing an `id`, `pattern`, and `message`. +1. The first way has an object providing an `id`, `pattern`, and `message`. 2. The second way is just the pattern. When this is used, the `id` is set equal to the pattern, and a generic message is provided for you. -3. The third way allows you to specify what capture-group the problematic thing - is in, in case your regex is complicated. +3. The third way allows you to specify what capture-group the problematic piece + of code is in, in case your regex is complicated and also matches characters + not useful in an error message. ### Error Messages -Error messages have access to the capture groups of the regex. Simply use `{$n}` -where `n` is the index of the capture group you wish to appear in that part of -the message. +Error messages have access to the capture groups of the regex. To access the +capture groups of the regex, use `{$n}` where `n` is the index of the capture +group you wish to appear in that part of the message. You can see this used in the 3rd example. diff --git a/scalafix-tests/input/src/main/scala/test/disableSyntax/DisableSyntaxBase.scala b/scalafix-tests/input/src/main/scala/test/disableSyntax/DisableSyntaxBase.scala index 4de873e17..be4f16b8e 100644 --- a/scalafix-tests/input/src/main/scala/test/disableSyntax/DisableSyntaxBase.scala +++ b/scalafix-tests/input/src/main/scala/test/disableSyntax/DisableSyntaxBase.scala @@ -60,7 +60,10 @@ case object DisableSyntaxBase { def -(other: String): String = s"$value - $other" } - 5 // assert: DisableSyntax.magicNumbers + 5 /* assert: DisableSyntax.magicNumbers + ^ +Numbers (5 in this instance) should always have a named parameter attached, or be assigned to a val. + */ val fortyTwo = 42 val someDays = 75.days