Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala.jdk.OptionConverters missing? #532

Closed
haukeh opened this issue May 18, 2022 · 2 comments
Closed

scala.jdk.OptionConverters missing? #532

haukeh opened this issue May 18, 2022 · 2 comments

Comments

@haukeh
Copy link
Contributor

haukeh commented May 18, 2022

Greetings,

while cross-building with Scala 2.12 and 2.13., I just stumbled upon the fact, that there is no scala.jdk.OptionConverters in this library. As CollectionConverters is present, I am wondering if there is a specific reason why OptionConverters was ommited.

Prior to Scala 2.13 the standard way to go (I guess) was using scala-java8-compat's scala.compat.java8.OptionConverters, so probably the idea was that most people would just keep using that instead of the 2.13 scala.jdk import?

Sorry if this is a weird question. It would be great to hear your opinions on this.

Best regards,
Hauke

@lrytz
Copy link
Member

lrytz commented May 18, 2022

I think it's an oversight / nobody asked or thought about it. #217 for reference. A contribution would be welcome!

@haukeh
Copy link
Contributor Author

haukeh commented May 19, 2022

Thanks for the quick reply, Lukas. I'd be willing to add the missing class(es) and create a PR, in fact I've already tried yesterday evening, but I'm struggling a little bit with the MultiScalaCrossProject. As OptionConverters references java.lang.Optional it would need to be included only for the JVM and for Scala 2.11/2.12. I'm still trying to figure out, in which source directory it would need to be for that to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants