Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message when a pattern match extractor is not found. #18725

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Better error message when a pattern match extractor is not found. #18725

merged 4 commits into from
Oct 19, 2023

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Oct 19, 2023

Fixes #18684

bishabosha
bishabosha approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@bishabosha bishabosha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, a possible improvement to the explanation could be to provide an example, e.g. if the user does not expect that its possible to put a pattern after val (I understand this also warning appears in standard match case)

@odersky odersky merged commit 3e105f2 into scala:main Oct 19, 2023
18 checks passed
@odersky odersky deleted the fix-#18684 branch October 19, 2023 16:19
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 21, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 22, 2024
@WojciechMazur
Backport "Better error message when a pattern match extractor is not …
5258c3c 
…found." to LTS (#20726)

Backports #18725 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

@bishabosha bishabosha bishabosha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

confusing "Not found" error when I change "def foo()" to "val foo()"
4 participants
@odersky @dwijnand @bishabosha @Kordyjan