Completions should prepend, not replace as it is for Scala 2 #18803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochala
added
the
area:presentation-compiler
kasiaMarek
approved these changes
Nov 2, 2023
Comment on lines
173
to
175
| val textEdit = range | ||
| .map(lspRange => new TextEdit(lspRange, newText)) | ||
| .getOrElse(new TextEdit(editRange, newText)) |
There was a problem hiding this comment.
Nit:
Suggested change
| val textEdit = range | |
| .map(lspRange => new TextEdit(lspRange, newText)) | |
| .getOrElse(new TextEdit(editRange, newText)) | |
| val textEdit = new TextEdit(range.getOrElse(editRange), newText) |
tgodzik
added
the
backport:nominated
WojciechMazur
pushed a commit
that referenced
this pull request
Jun 23, 2024
By default, in Scala 2 completion prepend and only replace if there is exact match. This PR unifies the experience between the Scala versions. It seems more intuitive to work that way. The change will be as follows (the order is: new logic, old logic and scala 2 logic): https://github.com/lampepfl/dotty/assets/48657087/c037c322-5613-4b95-a6e5-090b4e8827b6 In the future, it should be improved by changing implementation to use `InsertReplaceEdit` instead of `TextEdit`. This will allow users to decide which behaviour they prefer, but this has to be first implemented in metals to properly handle the new logic, but for now the key is to unify behaviours. https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#insertReplaceEdit [Cherry-picked dc1e35a]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, in Scala 2 completion prepend and only replace if there is exact match. This PR unifies the experience between the Scala versions. It seems more intuitive to work that way.
The change will be as follows (the order is: new logic, old logic and scala 2 logic):
Screen.Recording.2023-10-31.at.15.30.31.mov
In the future, it should be improved by changing implementation to use
InsertReplaceEditinstead ofTextEdit. This will allow users to decide which behaviour they prefer, but this has to be first implemented in metals to properly handle the new logic, but for now the key is to unify behaviours. https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#insertReplaceEdit