Space: Replace showType & make Space Showable #19370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace showType with a small tweak to RefinedPrinter, so the rest of the logic is followed. For instance, show infix types and tuples correctly. Also, make Space Showable, reusing the existing logic for Space, but additionally specifying the Space class name, which is important for following Space traces.
nicolasstucki
approved these changes
Jan 5, 2024
WojciechMazur
added a commit
that referenced
this pull request
Jun 28, 2024
Backports #19370 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace showType with a small tweak to RefinedPrinter, so the rest of
the logic is followed. For instance, show infix types and tuples
correctly.
Also, make Space Showable, reusing the existing logic for Space, but
additionally specifying the Space class name, which is important for
following Space traces.