Fix #19202: Passing NotNullInfos to a mutable field of a Completer #19463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shall we try giving all the completers a |
|
Yeah that might be the most sensible approach here, ideally we'd have a base class AbstractCompleter that keeps it abstract too |
|
(or keep Completer with the same name but make it abstract and add a concrete Term completer?) |
|
So, I think it is ok to keep NotNullInfos as a mutable field for now. |
noti0na1
force-pushed
the
create-correct-completer-when-passing-notnullinfos
branch
from
b4a293e
to
bc057db
Compare
smarter
approved these changes
Jan 19, 2024
| @@ -784,12 +785,18 @@ class Namer { typer: Typer => | |||
|
|
|||
| protected def localContext(owner: Symbol): FreshContext = ctx.fresh.setOwner(owner).setTree(original) | |||
|
|
|||
| private var myNotNullInfos: List[NotNullInfo] | Null = null | |||
|
|
|||
| /** The context with which this completer was created */ | |||
There was a problem hiding this comment.
The comment should mention that this is affected by setNotNullInfos
noti0na1
deleted the
create-correct-completer-when-passing-notnullinfos
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19202
Completing a
Defrequires the new NotNullInfos from previous statements.Originally, we created a new Completer with the new creation ctx in
adaptCreationContext.However, we should not create a regular Completer for
TypeDefs.This PR fixes the issue by creating a mutable field for NotNullInfos in Completer,
and the field is updated in
adaptCreationContextnow.There may be a better solution without the mutable field.