Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make eraseInfo work for classes with EmptyScopes #19550

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Make eraseInfo work for classes with EmptyScopes #19550

merged 6 commits into from
Jan 30, 2024

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jan 27, 2024 •
edited by noti0na1
Loading

Fixes #19530

@odersky odersky changed the title Don't transform infos of classes that get eliminated at erasure Make eraseInfo work for classes with EmptyScopes Jan 27, 2024
@odersky
Copy link
Contributor Author

odersky commented Jan 28, 2024

Closed in favor of #19553

@odersky odersky closed this Jan 28, 2024
@noti0na1 noti0na1 mentioned this pull request Jan 28, 2024
Closed
@odersky odersky reopened this Jan 28, 2024
@odersky
Copy link
Contributor Author

odersky commented Jan 28, 2024

!= vs ne made no difference.

@odersky odersky closed this Jan 28, 2024
@noti0na1 noti0na1 reopened this Jan 29, 2024
@noti0na1
Copy link
Member

It seems that using the names of symbols may break the order they are loaded at some places, so I use null as the default value when renaming is not needed.

@odersky
Copy link
Contributor Author

odersky commented Jan 30, 2024

LGTM. @noti0na1 If you can approve it, please do. It does not let me do it, since I originated the PR.

@odersky odersky assigned noti0na1 and unassigned odersky Jan 30, 2024
@noti0na1 noti0na1 linked an issue Jan 30, 2024 that may be closed by this pull request
classOf[scala.Singleton] compiler crash #19530
Closed
@noti0na1 noti0na1 merged commit f89f429 into scala:main Jan 30, 2024
16 checks passed
@noti0na1 noti0na1 deleted the fix-19530 branch January 30, 2024 16:06
@Kordyjan Kordyjan added this to the 3.4.1 milestone Feb 14, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jun 28, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 1, 2024
@WojciechMazur
Backport "Make eraseInfo work for classes with EmptyScopes" to LTS (#…
ae94fb6 
…20868)

Backports #19550 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He-Pin He-Pin He-Pin left review comments

@noti0na1 noti0na1 noti0na1 approved these changes

Assignees

@noti0na1 noti0na1

Labels
None yet
Projects
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.

classOf[scala.Singleton] compiler crash
4 participants
@odersky @noti0na1 @He-Pin @Kordyjan