Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#i18645): overload ext method body in braces didn't compile #19651

Merged
merged 2 commits into from
Feb 13, 2024
Merged

fix(#i18645): overload ext method body in braces didn't compile #19651

merged 2 commits into from
Feb 13, 2024

Commits on Feb 9, 2024

  1. fix(#i18645): overload ext method body in braces didn't compile 

    `tryWithImplicitOnQualifier` returned without attempting `tryInsertImplicitOnQualifier`,
which prevented the compiler from finding overloaded method, because `hasInnerErrors`
in `ProtoTypes` picked up the inner error propagated back from outer error.

When compiling `x.pprint(()=> { 123 })` before this commit, in `hasInnerErrors`,
`t` contains two sub trees; `Block(stmt, expr)` and `stmt`. The span of the former matches
the span of `t`, but that of the latter does not, which caused `hasInnerErrors` to return `true`,
but the error from the latter is duplicated with the error of parent tree `t`.
    @i10416
    i10416 committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    5cf6707 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/18645-overloaded-ext-method-compile-er… 

    …ror-with-braces
    @i10416
    i10416 committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    5a41b9c View commit details
    Browse the repository at this point in the history