Retain default parameters with export
#20167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default parameters need to have the `HasDefault` flag set to work properly, it seems that without this flag they were still selected but only under join compilation. While we're at it, we define a full set of flags that might be exported. Note that Given/Implicit/Erased were already set by `tpd.DefDef` and Inlined doesn't seem to make a difference in practice since the body of the exported inline def is manually constructed and doesn't contain proxies either way.
smarter
force-pushed
the
silence-ext-override
branch
from
be697af
to
1045571
Compare
|
Ist this perhaps a fix for #15031 ? (just remembering the issue and mentioning here for your convenience) |
|
Yes, thank you! |
odersky
approved these changes
Apr 13, 2024
smarter
added
the
backport:nominated
smarter
added a commit
that referenced
this pull request
Apr 18, 2024
WojciechMazur
removed
the
backport:nominated
WojciechMazur
added a commit
that referenced
this pull request
Jul 5, 2024
Backports #20167 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default parameters need to have the
HasDefaultflag set to work properly, it seems that without this flag they were still selected but only under join compilation.While we're at it, we define a full set of flags that might be exported. Note that Given/Implicit/Erased were already set by
tpd.DefDefand Inlined doesn't seem to make a difference in practice since the body of the exported inline def is manually constructed and doesn't contain proxies either way.