Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require organisation id in Annotation constructor. #1155

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Require organisation id in Annotation constructor. #1155

wants to merge 3 commits into from

Conversation

markbader
Copy link
Contributor

@markbader markbader commented Aug 1, 2024 •
edited
Loading

Description:

  • When calling the Annotation() constructor, an organisation_id is mandatory now. The organization_id might be provided directly within the Annotation() call, or it is inferred from current webknossos context.

Issues:

Todos:

Make sure to delete unnecessary points or to check all before merging:

  • Updated Changelog

@markbader markbader self-assigned this Aug 1, 2024
@markbader markbader marked this pull request as ready for review August 1, 2024 12:55
@normanrz
Copy link
Member

normanrz commented Aug 1, 2024

Not sure, I am happy with this. Providing an organization id might be cumbersome for users. And, I don't see why it wouldn't be possible to infer that upon upload.
Fwiw, we could even make the dataset name optional. It could be supplied upon upload.
cc @fm3

@markbader markbader mentioned this pull request Dec 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@markbader markbader

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload of wk.Annotation should require organization_id
2 participants
@markbader @normanrz