Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source files in the project root directory are not fixed #299

Closed
olafurpg opened this issue Aug 18, 2017 · 2 comments
Closed

Source files in the project root directory are not fixed #299

olafurpg opened this issue Aug 18, 2017 · 2 comments
Labels

Comments

@olafurpg
Copy link
Contributor

A project like this

Foobar.scala
build.sbt

will compile Foobar.scala (it's in sources) but scalafix won't fix it since the root directory is part of unmanagedSourceDirectories. I'm not sure which sbt setting is appropriate to use here besides sources. I prefer to avoid sources since that includes managed sources (code generated) which is pretty meaningless to fix. I might make sense to read sources in scalafix instead of unmanagedSourceDirectories by default.

Question is, should scalafix consider *.scala files in the baseDirectory?

@olafurpg olafurpg added the sbt label Aug 18, 2017
@olafurpg
Copy link
Contributor Author

It seems we can use

> help sourcesInBase
If true, sources from the project's base directory are included as main sources.

to decide whether to include *.scala files in the base directory.

@olafurpg
Copy link
Contributor Author

Duplicate of #340

@olafurpg olafurpg marked this as a duplicate of #340 Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant