Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Scala 2.13 #156

Closed
jdegoes opened this issue Mar 15, 2019 · 11 comments
Closed

Support Scala 2.13 #156

jdegoes opened this issue Mar 15, 2019 · 11 comments

Comments

@jdegoes
Copy link

jdegoes commented Mar 15, 2019

Any plans to cross-build for Scala 2.13?

@olafurpg
Copy link
Member

olafurpg commented Mar 15, 2019

Thanks for reporting! I’ve been planning to add Scala 2.13 support once the RC is out. I think I have publish rights for most of our transitive dependencies excluding ScalaTest so I don’t expect to encounter major blockers in the upgrade.

@jdegoes
Copy link
Author

jdegoes commented Mar 15, 2019

@olafurpg Awesome! Thank you for looking into this.

More context here

@olafurpg
Copy link
Member

The traditional way to use the mdoc plugin is only enable it for a single “docs” project in the build that is not published. I’m not sure how microsite uses mdoc but I’m surprised if lack of 2.13 support should be a blocker for 2.13 crossbuilt libraries. The docs are usually only compiled against one Scala versions.

@jdegoes
Copy link
Author

jdegoes commented Mar 15, 2019

@olafurpg

More information:

  • skip in publish := true is set in the microsite project
  • microsite is the only project using the plug-in
  • Despite the above and also trying to exclude scalameta mdoc from transitive dependencies, publishLocal still fails due to non-existence of 2.13

My sbt-fu is weak though. I may be missing something obvious.

@olafurpg
Copy link
Member

What is the value of “crossScalaVersions”?

@jdegoes
Copy link
Author

jdegoes commented Mar 15, 2019

crossScalaVersions := Seq("2.12.8", "2.13.0-M5")

@olafurpg
Copy link
Member

Does publishLocal work if you set crossScalaVersions := Seq("2.12.8") in the docs project?

If that works, then we  improve the error message in sbt-mdoc to give actionable feedback on how to fix the resolution error for unsupported Scala versions.

@jdegoes
Copy link
Author

jdegoes commented Mar 16, 2019

@olafurpg Will try and report back.

@gabro
Copy link
Member

gabro commented Jun 15, 2019

For the record, cross building for 2.13.0 is currently blocked by the lack of 2.13.0 binaries for:

Here's a WIP PR #173

@gabro
Copy link
Member

gabro commented Aug 6, 2019

Actually, monadic-html is only used in the documentation, so it should be fine. We're currently only blocked by metaconfig (working on it!)

@olafurpg
Copy link
Member

Fixed in #184, waiting for CI to release 1.3.2 https://travis-ci.org/scalameta/mdoc/builds/576584631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants