Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to implementation for dependency sources #119

Closed
Z1kkurat opened this issue May 6, 2020 · 4 comments
Closed

Go to implementation for dependency sources #119

Z1kkurat opened this issue May 6, 2020 · 4 comments

Comments

@Z1kkurat
Copy link

Z1kkurat commented May 6, 2020

Describe the bug
VSCode + Metals fails to find trait implementations in dependency's source files, for Doobie in particular (when using in project that depends on doobie as a dependency).

To Reproduce
Steps to reproduce the behavior:

  1. Any project which has doobie dependency will do
  2. Go to sources, in particular doobie.free.preparedstatement
  3. Right-click on trait Visitor inside object PreparedStatementOp, choose Go to implementations
  4. See No implementation found for Visitor

Expected behavior
Implementations are shown in pop-up window. If you try to do this while in doobie's source repository, it works fine. Clean compiles don't help either.

Screenshots
image

Installation:

  • Operating system: Windows and Linux
  • Editor: Visual Studio Code
  • Metals version: v0.9.0

Search terms
doobie

@tgodzik
Copy link
Contributor

tgodzik commented May 6, 2020

Thanks for reporting! That is currently expected, since we don't index the inheritance graph inside the dependencies. It would be a good improvement for sure, but it might be quite hard to achieve efficiently.

@tgodzik tgodzik changed the title No implementation found for traits in dependency's source Go to implementation for dependency sources May 7, 2020
@tgodzik tgodzik transferred this issue from scalameta/metals May 7, 2020
@Z1kkurat
Copy link
Author

Z1kkurat commented Apr 7, 2021

@tgodzik Are there any plans to support this? This would be a really game-killer feature IMHO. I think many users currently have to switch to IDEA to get that functionality.

@tgodzik
Copy link
Contributor

tgodzik commented Apr 7, 2021

There are certainly plans, but we've not been able to work on it just yet. It also depends on scalameta/metals#1287 which should allow us to effectively query the classpath.

@tgodzik
Copy link
Contributor

tgodzik commented Mar 28, 2024

This is now working for both Scala and Java

@tgodzik tgodzik closed this as completed Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants