Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting munitTimeout = Duration.Inf fails #572

Closed
armanbilge opened this issue Sep 7, 2022 · 0 comments · Fixed by #768
Closed

setting munitTimeout = Duration.Inf fails #572

armanbilge opened this issue Sep 7, 2022 · 0 comments · Fixed by #768

Comments

@armanbilge
Copy link
Contributor

armanbilge commented Sep 7, 2022 •
edited
Loading

Calling .toMillis on a non-finite Duration throws an error.

munit/munit/jvm/src/main/scala/munit/internal/PlatformCompat.scala

Line 42 in 166698e

duration.toMillis,

So either the type should be refined to FiniteDuration, if that is what is expected, or this case should be specially handled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle infinite timeouts mzuehlke/munit
1 participant
@armanbilge