Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract the Printers into munit-diff #826

Closed
msosnicki opened this issue Sep 16, 2024 · 3 comments
Closed

Extract the Printers into munit-diff #826

msosnicki opened this issue Sep 16, 2024 · 3 comments

Comments

@msosnicki
Copy link

In the #756 munit-diff was extracted, so that it can be used outside of munit context, as it is a very useful micro library.

The diffing mechanism is based on class Diff(val obtained: String, val expected: String), where a string representation of a datatype is expected. It is optimized for the Printers, which are currently in munit module (for toString it doesn't work as nicely, in munit it is merely a fallback mechanism if Printers do not reveal any difference).

I can work on extracting it into munit-diff, but wanted to ask for green light here, maybe there are some gotchas that I missed and it was left out on purpose.

@tgodzik
Copy link
Contributor

tgodzik commented Sep 16, 2024

I don't remember any issues, but maybe @majk-p does? I think we just wanted to extract the smallest possible part.

@majk-p
Copy link
Contributor

majk-p commented Sep 16, 2024

Cant tell for sure, but likely it was due to Printers dependency on munit.Clue, which we didn't want to include in munit.diff.

@msosnicki
Copy link
Author

I'm closing this issue, turns out there is an ongoing effort to have the pretty diffing baked into weaver as part as ongoing migration to typelevel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants