Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scalapb grpc runtime & InProcessTransport #1614

Closed
hugebdu opened this issue Nov 27, 2023 · 4 comments · Fixed by #1615
Closed

scalapb grpc runtime & InProcessTransport #1614

hugebdu opened this issue Nov 27, 2023 · 4 comments · Fixed by #1615

Comments

@hugebdu
Copy link
Contributor

hugebdu commented Nov 27, 2023

Hello codegen wizards.

Any plans/thoughts on skipping the serialization completely like in java-grpc in case the InProcessTransport is used?
@thesamet
Copy link
Contributor

This wasn't on my list - PR will be welcome!

@hugebdu
Copy link
Contributor Author

hugebdu commented Nov 28, 2023 •
edited
Loading

@thesamet thanks for your quick response.
I can give it a try.
May I ask which IDE you're using? CONTIBUTING.md does not mention anything about it.
I tried using IntelliJ IDEA, however seems like it has a problem with sbt-projectmatrix

UPD: managed with the IDEA - manually removed redundant submodules after project import

@hugebdu hugebdu mentioned this issue Nov 28, 2023
Merged
@hugebdu
Copy link
Contributor Author

hugebdu commented Dec 3, 2023

@thesamet Thanks!

@thesamet
Copy link
Contributor

thesamet commented Dec 5, 2023

@hugebdu Sorry for missing the question up there - but I use VS Code with Metals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scalapb-runtime-grpc: optimize Marshaller for InProcessTransport hugebdu/ScalaPB
2 participants
@thesamet @hugebdu