Addressable post messages. #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… addressable post messages.
idanilt
changed the title
# Conflicts: # yarn.lock
packages/addressable/src/Node.ts
Outdated
| */ | ||
| public subscribe(fn: (peer: Peer) => void): () => void { | ||
| // Peers act like unique reply subject | ||
| return map((o: Peer) => ({ id: o.key, port: o.value }), eachUnique(this.peers$)).subscribe(fn); |
There was a problem hiding this comment.
Will not emit anything when a peer is removed.
There was a problem hiding this comment.
I didn't handle it yet
There was a problem hiding this comment.
I fix it, it will emit {id, undefined}
packages/addressable/src/Node.ts
Outdated
| * | ||
| * @param id | ||
| */ | ||
| public remove(id: string) { |
There was a problem hiding this comment.
No one is using this (and it's not covered by any use case defined in tests)
There was a problem hiding this comment.
I didn't handle it yet
|
@idanilt CI ran for 6 hours, converting this PR to draft to avoid new run before it will be fixed. |
katzIdo
reviewed
Jul 29, 2020
# Conflicts: # packages/browser/package.json # packages/cluster-browser/package.json # packages/cluster-nodejs/package.json # packages/node/package.json # packages/routers/package.json # packages/rsocket-adapter/package.json # packages/rsocket-ws-gateway/package.json # packages/scalecube-discovery/package.json # packages/scalecube-microservice/package.json # packages/transport-browser/package.json # packages/transport-nodejs/package.json # packages/utils/package.json
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use scalecube in the browser we need infrastructure to send and receive messages
At this moment we don't have it as result our cluster and transport implementation is much more complex than it should be
Beside that we need extra utils and it's not working for all the use cases
Addressable package will hide the complexity and allow scalecube to work very similar to server implementation and utilize the addresses
#256