Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Modal): focus on close #3967

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix(Modal): focus on close #3967

merged 1 commit into from
Jul 5, 2024

Conversation

lisalupi
Copy link
Contributor

@lisalupi lisalupi commented Jul 4, 2024

Summary

Type

  • Bug

Summarise concisely:

What is expected?

<Modal />: when a modal is closed, focus should be on disclosure
This also fixes the issue for MenuV2.item when it is used with a modal.

@lisalupi lisalupi added the bug Something isn't working label Jul 4, 2024
@lisalupi lisalupi requested review from philibea and matthprost July 4, 2024 15:39
@lisalupi lisalupi self-assigned this Jul 4, 2024
Copy link

changeset-bot bot commented Jul 4, 2024

🦋 Changeset detected

Latest commit: 37d35b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.15%. Comparing base (3e74f91) to head (37d35b6).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3967   +/-   ##
=======================================
  Coverage   94.15%   94.15%           
=======================================
  Files         184      184           
  Lines        5983     5984    +1     
  Branches     2661     2698   +37     
=======================================
+ Hits         5633     5634    +1     
  Misses        350      350           
Files Coverage Δ
packages/ui/src/components/Modal/Disclosure.tsx 92.85% <ø> (-0.48%) ⬇️
packages/ui/src/components/Modal/index.tsx 97.56% <100.00%> (+0.12%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35f5813...37d35b6. Read the comment docs.

@lisalupi lisalupi merged commit 3a97e74 into main Jul 5, 2024
12 checks passed
@lisalupi lisalupi deleted the fix/menuv2-modal-focus branch July 5, 2024 08:41
This was referenced Jul 4, 2024
matthprost added a commit that referenced this pull request Jul 9, 2024
matthprost added a commit that referenced this pull request Jul 9, 2024
matthprost added a commit that referenced this pull request Jul 9, 2024
philibea pushed a commit that referenced this pull request Jul 9, 2024
This reverts commit 3a97e74.

Signed-off-by: Alexandre Philibeaux <aphilibeaux@scaleway.com>
philibea pushed a commit that referenced this pull request Jul 9, 2024
This reverts commit 3a97e74.

Signed-off-by: Alexandre Philibeaux <aphilibeaux@scaleway.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants