-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Modal): focus on close #3967
Conversation
🦋 Changeset detectedLatest commit: 37d35b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3967 +/- ##
=======================================
Coverage 94.15% 94.15%
=======================================
Files 184 184
Lines 5983 5984 +1
Branches 2661 2698 +37
=======================================
+ Hits 5633 5634 +1
Misses 350 350
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This reverts commit 3a97e74.
This reverts commit 3a97e74.
Summary
Type
Summarise concisely:
What is expected?
<Modal />
: when a modal is closed, focus should be on disclosureThis also fixes the issue for MenuV2.item when it is used with a modal.