Object.values is not a function

[amillward]

Hi,

I use react-alert throughout my site, and Sentry is telling me I'm getting many of this error each day;

I have not been able to reproduce the error, and I can't see from looking at the code why this would be happening. Anyone else having this issue or can spot what may be going on?

react-alert@5.5.0
react@16.8.6

Thanks

[schiehll]

Hi @amillward!

So you are probably getting this error when someone accesses your site via IE:

I think this was introduced when @besLisbeth added the constants for positions, types, transitions, etc...I could be wrong tho.

You can add a polyfill for it in your site, or maybe we could change it to something like:

Object.keys(positions).map(position => positions[position])

PRs are welcome.

[amillward]

That was actually my first guess too, but Sentry is reporting a majority Safari/iPad users... :(

There's a chance Sentry is doing something weird with the error merging? Perhaps it's worth trying the polyfill/fix for IE first and seeing if the issue continues

[schiehll]

Yeah, probably old devices running old versions of browsers...but the solutions stands: You can fix it by adding a polyfill for Object.values to your site, and we can also change the code for something else.

[schiehll]

It's fixed now in v6, thanks for reporting!

[ConcealGeek]

It's fixed now in v6, thanks for reporting!

in v6:

react-alert/src/Provider.js

Line 125 in 5229d32

{Object.values(positions).map(position => (

There's a object.values() here that's forgotten