Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on attrs package should be explicit #179

Closed
bluetech opened this issue Jan 18, 2023 · 3 comments · Fixed by #180
Closed

Dependency on attrs package should be explicit #179

bluetech opened this issue Jan 18, 2023 · 3 comments · Fixed by #180

Comments

@bluetech
Copy link

Hi, I'm one of the pytest maintainers.

I am working on a PR to pytest that will remove the attrs dependency. This means that plugins that use attrs but do not explicitly require it will break. From a search among pytest plugins, I found that pytest-mock-resources is one such plugin.

attrs is used in this file: https://github.com/schireson/pytest-mock-resources/blob/d522be82cd3a08b886fb504429b315f30d7280eb/src/pytest_mock_resources/patch/redshift/mock_s3_copy.py

@bluetech
Copy link
Author

The pytest PR is this: pytest-dev/pytest#10669

@DanCardin
Copy link
Contributor

Thanks for the report! The use of attrs there is really unnecessary anyways

@DanCardin
Copy link
Contributor

v2.6.7 wont have this defect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants