Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the "sticky locale" functionality more configurable #230

Open
gitcerizead opened this issue Nov 30, 2018 · 1 comment
Open

Make the "sticky locale" functionality more configurable #230

gitcerizead opened this issue Nov 30, 2018 · 1 comment

Comments

@gitcerizead
Copy link

Feature request

This bundle features a sophisticated sticky locale implementation, and the sticky locale is applied on routes for which "translation" (i18n) is disabled; see #229 .

It would be great if this functionality could be more configurable. Sometimes I won't want to have cookies being set (see also #210 ), for example. But the thing I'd most like to be able to configure is whether or not Accept-Language request headers are used. They are used in the current implementation, but there are situations in which I'd prefer to use the configured default language rather than rely on the (notoriously unreliable) Accept-Language header.

@gitcerizead gitcerizead changed the title Make the "sticky locale" functionality more configurable Make the "sticky locale" functionality be more configurable Nov 30, 2018
@gitcerizead gitcerizead changed the title Make the "sticky locale" functionality be more configurable Make the "sticky locale" functionality more configurable Nov 30, 2018
@gitcerizead
Copy link
Author

On the other hand, the "stickiness" is achieved solely through the use of a cookie called 'hl', which may be being set in error (i.e. the stickiness feature may be a bug rather than a feature!). See #210 . But even it's decided to remove the stickiness feature, it would still be good to be able to configure how the default locale is determined for a route for which "translation" (i18n) is disabled, as per the description in this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant