-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IIIF Print's permissions should propagate down to its children #347
Comments
TODO: merge split work in so that we can test this. cc @laritakr |
TODO: Test via Bulkrax and UI |
QA blocked until it is updated in the knapsack apps |
QA RESULTS: BLOCKEDPals knapsack importer is not working. I first uploaded a csv that were missing headers and the errors did not get reported. Sample CSV (missing headers) - i347-qa-error.zip perhaps #status_info needs to be updated to #set_status_info def valid_import?
missing_fields_by_model = records.each_with_object({}) do |record, hash|
record.compact!
record.transform_keys!(&:downcase).transform_keys!(&:to_sym)
missing_fields = missing_fields_for(record)
hash[record[:model]] = missing_fields if missing_fields.present?
end
raise_error_for_missing_fields(missing_fields_by_model) if missing_fields_by_model.keys.present?
file_paths.is_a?(Array)
rescue StandardError => e
importer.set_status_info(e)
false
end After that, I corrected the headers and imported, but get a NoMethodError: #find is returning false Sample CSV: |
To Do:
|
QA RESULTS:
|
Yes, the file sets showing in the list are, I believe, due to some change in Hyrax. I filed a bug ticket for it a while back. The file set not getting lease/embargo I believe also comes from Hyrax. There may have been a failure in the job that propagates the permission from the child work to the fileset. However I don't consider it a serious problem because
|
Summary
Timebox: 8hrs
Acceptance Criteria
Screenshots or Video
Testing Instructions
Notes
Look into Hyrax Propagator service as an option. And/or adding the new properties in iiif print (but is it readable?)
samvera/bulkrax#950
The text was updated successfully, but these errors were encountered: