fix: minor optimizations for ufuncs #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
commented
Jul 28, 2022
| if ufunc is np.equal and method == "__call__" and len(inputs) == 2: | ||
| return ufunc(np.asarray(inputs[0]), np.asarray(inputs[1]), **kwargs) # type: ignore[no-any-return] | ||
| # Avoid infinite recursion | ||
| raw_inputs = [np.asarray(x) for x in inputs] |
There was a problem hiding this comment.
This allows us to avoid special casing ==; it was recursing before.
henryiii
commented
Jul 28, 2022
Comment on lines
-118
to
+119
| (result,) = kwargs.pop("out", [np.empty(self.shape, self.dtype)]) | ||
| (result,) = ( | ||
| kwargs.pop("out") | ||
| if "out" in kwargs | ||
| else [np.empty(self.shape, self.dtype)] | ||
| ) |
There was a problem hiding this comment.
Avoids a temporary useless allocation if out is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered minor improvements when preparing teaching material for next week.