Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Update Numpy 1.20 to 1.21 for mypy #245

Closed
LovelyBuggies opened this issue Jun 28, 2021 · 2 comments
Closed

[FEATURE] Update Numpy 1.20 to 1.21 for mypy #245

LovelyBuggies opened this issue Jun 28, 2021 · 2 comments
Assignees
@henryiii @LovelyBuggies
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@LovelyBuggies
Copy link
Collaborator

LovelyBuggies commented Jun 28, 2021 •
edited by amangoel185
Loading

We have added types to ndarray, which requires NumPy 1.21 support. We are supposed to make this update for mypy entry in the pre-commit-config.

Probably will hit boost-histogram, too.
@LovelyBuggies LovelyBuggies added the enhancement New feature or request label Jun 28, 2021
This was referenced Jun 28, 2021
Merged
Merged
Merged
@henryiii henryiii added the good first issue Good for newcomers label Jul 17, 2021
@henryiii
Copy link
Member

henryiii commented Aug 9, 2021 •
edited by amangoel185
Loading

We need:

  • np.ndarray -> np.typing.NDArray[Any] (or use the actual DType here)
  • Add strings around the expressions in boost-histogram (Hist is okay)
  • Bump the version to 1.21 in pre-commit
  • Bump the version to 1.14.5 in setup.cfg

@amangoel185 amangoel185 mentioned this issue Aug 10, 2021
Merged
@amangoel185 amangoel185 reopened this Aug 10, 2021
@amangoel185
Copy link
Collaborator

Fix completed for boost-histogram too with #625 in Boost-histogram.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henryiii henryiii

@LovelyBuggies LovelyBuggies

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@henryiii @amangoel185 @LovelyBuggies